added device= method to set the device based on name or number #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This worked great! Thanks |
| @@ -118,6 +139,10 @@ def fan_mode=(state) | |||
| ) rescue nil | |||
| end | |||
|
|
|||
| # def name | |||
There was a problem hiding this comment.
Did you mean to leave this in? If so, uncomment it else remove please.
Also, could you add tests for this PR?
|
While this is a useful feature, I think that, when using multiple devices, it would be more appropriate to have a Device class that has the methods that Nest currently has (such as For this reason, I think that this should be closed in favor of #12 |
|
@stevenpetryk Yeah. I agree. I think it may have worked at the time but #12 is much more OO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For accounts with multiple devices, this allows a device to be specified by either name or number (0, 1, 2, etc):
I've tested this and it works great. Unfortunately I don't have specs for it.